optimize code in productcontroller methods store and update

app/Http/Controllers/ProductController.php

@@ -39,21 +39,39 @@ class ProductController extends Controller
      */
     public function store(/*Request $request*/)
     {
-        request()->validate([
-            'reference' => 'required',
-            'description_short' => 'required',
-            'description_long' => 'required',
-            'price' => 'required',
-            'type' => 'required'
-        ]);
+//        request()->validate([
+//            'reference' => 'required',
+//            'description_short' => 'required',
+//            'description_long' => 'required',
+//            'price' => 'required',
+//            'type' => 'required'
+//        ]);
+//
+//        $product = new Product();
+//        $product->reference = request('reference');
+//        $product->description_short = request('description_short');
+//        $product->description_long = request('description_long');
+//        $product->price = request('price');
+//        $product->type = request('type');
+//        $product->save();
+
+//        Product::create([
+//            'reference' => request('reference'),
+//            'description_short' => request('description_short'),
+//            'description_long' => request('description_long'),
+//            'type' => request('type'),
+//            'price' => request('price')
+//        ]);
+//
+//        Product::create(request()->validate([
+//            'reference' => 'required',
+//            'description_short' => 'required',
+//            'description_long' => 'required',
+//            'type' => 'required',
+//            'price' => 'required'
+//        ]));
 
-        $product = new Product();
-        $product->reference = request('reference');
-        $product->description_short = request('description_short');
-        $product->description_long = request('description_long');
-        $product->price = request('price');
-        $product->type = request('type');
-        $product->save();
+        Product::create($this->validateProduct());
 
         return redirect('/');
     }
@@ -85,8 +103,6 @@ class ProductController extends Controller
      */
     public function edit(Product $product)
     {
-//        $product = Product::findOrFail($product);
-
         return view('product.edit', compact('product'));
     }
 
@@ -97,23 +113,24 @@ class ProductController extends Controller
      * @param  \App\Product  $product
      * @return \Illuminate\Http\Response
      */
-    public function update(/*Request $request, Product $product*/ $product)
+    public function update(/*Request $request,*/ Product $product )
     {
-        request()->validate([
-            'reference' => 'required',
-            'description_short' => 'required',
-            'description_long' => 'required',
-            'price' => 'required',
-            'type' => 'required'
-        ]);
+//        request()->validate([
+//            'reference' => 'required',
+//            'description_short' => 'required',
+//            'description_long' => 'required',
+//            'price' => 'required',
+//            'type' => 'required'
+//        ]);
+//
+//        $product->reference = request('reference');
+//        $product->description_short = request('description_short');
+//        $product->description_long = request('description_long');
+//        $product->price = request('price');
+//        $product->type = request('type');
+//        $product->save();
 
-        $product = Product::find($product);
-        $product->reference = request('reference');
-        $product->description_short = request('description_short');
-        $product->description_long = request('description_long');
-        $product->price = request('price');
-        $product->type = request('type');
-        $product->save();
+        $product->update($this->validateProduct());
 
         return redirect("/product/{$product->id}");
     }
@@ -128,4 +145,15 @@ class ProductController extends Controller
     {
         //
     }
+
+    public function validateProduct()
+    {
+        return request()->validate([
+            'reference' => 'required',
+            'description_short' => 'required',
+            'description_long' => 'required',
+            'price' => 'required',
+            'type' => 'required'
+        ]);
+    }
 }

app/Product.php

@@ -6,5 +6,6 @@ use Illuminate\Database\Eloquent\Model;
 
 class Product extends Model
 {
-    //
+    protected $fillable = ['reference', 'description_short', 'description_long', 'type', 'price'];
+//    protected  $guarded = []; //remove protection against mass assignment
 }